Merged
Conversation
|
Channel deleted. |
Test Results 72 files 495 suites 0s ⏱️ Results for commit 0ecff79. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0ecff79 |
samadDotDev
force-pushed
the
reprofile-on-camera-info-changed-main
branch
from
b6dba12 to
5091303
Compare
samadDotDev
requested review from
ctowns,
hcarter-775,
nickolas-deboom,
tpmanley and
z-michel
samadDotDev
force-pushed
the
reprofile-on-camera-info-changed-main
branch
from
5091303 to
23ff223
Compare
hcarter-775
reviewed
Mar 26, 2026
drivers/SmartThings/matter-switch/src/sub_drivers/camera/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
approved these changes
Mar 26, 2026
tpmanley
reviewed
Mar 26, 2026
ctowns
approved these changes
Mar 26, 2026
tpmanley
approved these changes
Mar 26, 2026
samadDotDev
force-pushed
the
reprofile-on-camera-info-changed-main
branch
from
cafed54 to
0ecff79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds camera reprofiling on
infoChangedwhen the device's software version changes and camera device types are present.It aligns with existing reprofiling behavior in parent cfg of
matter-switch(and elsewhere), and ensures devices that initially onboard without camera endpoints can switch to the camera profile after a firmware update that introduces camera-related device types.Test coverage was expanded to include a bridge-style mock that starts without camera endpoints and later receives them with a software version bump. This validates the lazy subdriver path where camera
can_handlebecomes true after onboarding and confirms camerainfoChangedreprofiling executes correctly.